Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r\virtual_machine_data_disk_attachment: Fix panic with disk id is wrong #15470

Merged
merged 1 commit into from
Feb 17, 2022
Merged

r\virtual_machine_data_disk_attachment: Fix panic with disk id is wrong #15470

merged 1 commit into from
Feb 17, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Feb 17, 2022

Fix #15436

parsedId is nil when error occurs, which would cause a panic when dereferencing it. Use id from the parameter instead

@myc2h6o myc2h6o mentioned this pull request Feb 17, 2022
Closed
tombuildsstuff
tombuildsstuff approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.97.0 milestone Feb 17, 2022
@tombuildsstuff tombuildsstuff added service/disks service/disk-attachments Virtual Machine Disk Attachments and removed service/disks labels Feb 17, 2022
@tombuildsstuff tombuildsstuff merged commit 7ee0c20 into hashicorp:main Feb 17, 2022
tombuildsstuff added a commit that referenced this pull request Feb 17, 2022
@tombuildsstuff
updating to include #15470
9ce9e71
@myc2h6o myc2h6o deleted the disk_attach_panic_fix branch February 18, 2022 02:42
@github-actions
Copy link

This functionality has been released in v2.97.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@fvdnabee fvdnabee mentioned this pull request Mar 9, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
service/disk-attachments Virtual Machine Disk Attachments size/XS
Projects
None yet
Milestone
v2.97.0
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_machine_data_disk_attachment crashes if attaching are shared disk via a module
2 participants
@myc2h6o @tombuildsstuff